@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1663

Please review/lgtm -- @nvazquez @borisstoyanov and others
@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

This PR has changes in db upgrade path, to avoid adding a new db upgrade path b/w 4.11.0->4.11.1, and 4.11.1 or 4.11.0->4.12.0 (-snapshot) I think we should consider this merge towards 4.11.0 milestone and to make it into RC2. /cc @wido @rafaelweingartner @nvazquez @mike-tutkowski and others - please review

I did not understand why this change will avoid us having an upgrade path between 4.11 - 4.12.
@DaanHoogland can you provide some extra details here?

@rafaelweingartner this will add complexity that's all, ideally, we should n't (or at least try not to) have db changes in minor/dot releases.

Ah, now I got it.
You say, add this now, so we do not need to create upgrade paths for the minor version 4.11.1.0
Is that it?

Yes @rafaelweingartner that's it.

It seems to be something simple. However, I have no clues why you are changing a field in the database from not null to null able. I checked the Jira ticket, and it is a generic one regarding a feature that you were/are developing.

It is always good to provide these details either in the Jira ticket you create for the PR, or in the PR description itself. I also checked the commit, but it does not provide information regarding the necessity for this change and the impacts it may cause.

@rafaelweingartner it is a generic quality of settings that they are null able. I booboo'd here by making them non null. The code is really just part of the general functionality.

@rhtyd I will remove 4.11.1 milestone as it would have to be a alter table statement if it needs to go in there.

Trillian test result (tid-2174)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 20493 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2413-t2174-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Based on the code and the comments in this PR, LGTM.

Tests LGTM, Merging this based on code reviews and test result.